Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize some code logic #202

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Conversation

fanhaouu
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

  1. Only watch events for pods, nsr, and nodes on this node, while reducing memory usage;
  2. Resolve the issue of potential mount/umount failures when an NFS system exists on the node;

Special notes for your reviewer:
no

Does this PR introduce a user-facing change?:

The memory usage of the Carina node will be reduced by approximately 50%, or even more

@fanhaouu fanhaouu requested a review from antmoveh March 26, 2024 11:18
@fanhaouu fanhaouu self-assigned this Mar 26, 2024
@antmoveh
Copy link
Contributor

原先就注意到当nfs挂了时候会导致问题。当前的代码中有一段跳过检查的逻辑

@antmoveh
Copy link
Contributor

/lgmt

@antmoveh
Copy link
Contributor

approve

@antmoveh antmoveh added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Mar 27, 2024
@antmoveh antmoveh merged commit ec196cd into carina-io:main Mar 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants