-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Vale styles to fix Kafka-k8s docs false positive results #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove redundant changes that can't be justified by the main goal: repo is not a contraction and updating error messages is out of scope for this PR.
izmalk
commented
Aug 1, 2024
izmalk
commented
Aug 1, 2024
izmalk
changed the title
Suggestions to Style guide to fix false positive in Kafka docs Vale tests
Updating Vale styles to fix false positive results
Aug 1, 2024
izmalk
changed the title
Updating Vale styles to fix false positive results
Updating Vale styles to fix Kafka-k8s docs false positive results
Aug 1, 2024
medubelko
reviewed
Aug 1, 2024
I'm happy with adding extra issues for any more tweaks required to this, would be good to land the useful bits |
evilnick
previously approved these changes
Aug 8, 2024
SecondSkoll
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These suggestions are based on fixing false positive results of Vale tests for Kafka-k8s charmed operator documentation.