Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Configure e2e-wine UAT to run behind proxy #115

Merged
merged 4 commits into from
Sep 5, 2024

Conversation

orfeas-k
Copy link
Contributor

@orfeas-k orfeas-k commented Sep 2, 2024

Configure the pipeline steps in the test to run behind proxy, according to what we do for kfp-v2 UAT.

Closes #107
Fixes #116

Copy link
Contributor

@NohaIhab NohaIhab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job @orfeas-k , I saw the pipeline and the full UAT succeed behind proxy:
Screenshot from 2024-09-03 22-31-32

Left some nitty suggestions

README.md Show resolved Hide resolved
Copy link
Contributor

@NohaIhab NohaIhab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx @orfeas-k

@orfeas-k orfeas-k merged commit 109a69f into main Sep 5, 2024
1 check passed
@orfeas-k orfeas-k deleted the kf-6149-configure-e2e-behind-proxy branch September 5, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indentation error in e2e-wine notebook Configure e2e-wine UAT behind proxy
2 participants