Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build!: update cool-seq-tool + ga4gh.vrs versions #528

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Conversation

korikuzma
Copy link
Member

@korikuzma korikuzma commented Jan 11, 2024

close #408

Notes:

@korikuzma korikuzma added priority:medium Medium priority build Changes that affect the build system or dependencies labels Jan 11, 2024
@korikuzma korikuzma self-assigned this Jan 11, 2024
jsstevenson
jsstevenson previously approved these changes Jan 11, 2024
@korikuzma
Copy link
Member Author

I think I'm waiting for #529 to be approved before I merge this. This is because gnomad_vcf_to_protein work is broken in this, but #529 files it

@korikuzma
Copy link
Member Author

For the sake of transitioning to serverless, I'm just going to comment out the gnomad_vcf_to_protein work and merge this PR.

@korikuzma
Copy link
Member Author

Linting will be resolved in a separate PR

@korikuzma korikuzma added priority:high High priority and removed priority:medium Medium priority labels Feb 2, 2024
Copy link
Member

@jsstevenson jsstevenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jsstevenson
Copy link
Member

Linting will be resolved in a separate PR

enjoy

@korikuzma
Copy link
Member Author

@jsstevenson I already regret assigning the issue to myself

@korikuzma korikuzma merged commit 156ebeb into staging Feb 5, 2024
8 of 10 checks passed
@korikuzma korikuzma deleted the issue-408 branch February 5, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Changes that affect the build system or dependencies priority:high High priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants