fix: attempting to subscript an object #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah this has to do with pre/post validation and whether the object has been constructed recursively yet. I believe there are some changes within Pydantic releases as to how/whether this works. |
korikuzma
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this comment: cancervariants/fusion-curation#314 (comment) seems to have uncovered this issue. I don't really know why/how this ever worked? You can see on line 514, it's implied that this is an object, so I'm not sure why on line 516 we're attempting to subscript the object.
I could be totally off on this, but I'm going to open this PR just in case! This could be a good discussion :D