Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upload logs to GHA #2507

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

fix: upload logs to GHA #2507

wants to merge 4 commits into from

Conversation

jessesimpson36
Copy link
Contributor

Which problem does the PR fix?

At the end of the installation process, we should upload the logs and pod status regardless of whether it was a successful run or not, because users of our integration test workflow may experience an error that our healthchecks don't cover.

What's in this PR?

This PR will upload logs and pod status to GHA to help with debugging.

One drawback to this implementation is that it gives you pod status's and logs at the end of the workflow, and not at the end of the callers workflow. this may be insufficient. A less primitive solution may be to set up a logging provider like Splunk or ELK and provide access to it.

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

@jessesimpson36 jessesimpson36 self-assigned this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant