Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding TLS support to console #2505

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: adding TLS support to console #2505

wants to merge 4 commits into from

Conversation

hamza-m-masood
Copy link
Contributor

Which problem does the PR fix?

closes: #1850

What's in this PR?

I have added two new keys in the values.yaml that references certificates, and a key that references a filename.
I created a volume and volumeMount in console deployment, and reference the key from the values.yaml in the env var.

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

@hamza-m-masood hamza-m-masood marked this pull request as ready for review October 24, 2024 11:16
@hamza-m-masood hamza-m-masood requested a review from a team October 24, 2024 11:16
@hamza-m-masood hamza-m-masood self-assigned this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] Add a custom trust store to Console
1 participant