Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Using OpenShift routes for integration tests #2042

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

hamza-m-masood
Copy link
Contributor

Which problem does the PR fix?

related issue: https://github.com/camunda/distribution/issues/254

What's in this PR?

Modifying integration tests to use OpenShift routes.

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

@hamza-m-masood hamza-m-masood self-assigned this Jun 24, 2024
@hamza-m-masood hamza-m-masood added area/ci version/next To be part of the next release labels Jun 24, 2024
@hamza-m-masood hamza-m-masood added this to the 8.6 Release Cycle milestone Jun 24, 2024
@hamza-m-masood hamza-m-masood added test-persistent Don't delete the Helm deployment created by the PR and use fixed names and removed test-persistent Don't delete the Helm deployment created by the PR and use fixed names labels Jun 25, 2024
@hamza-m-masood hamza-m-masood marked this pull request as ready for review June 27, 2024 19:17
@hamza-m-masood
Copy link
Contributor Author

@aabouzaid I am finished with this values.yaml for OpenShift but I don't know how to incorporate it in our CI. There are three problems:

  1. OpenShift routes operator is not currently working in our CI
  2. I have hardcoded the namespace in the broker contact-point env vars. The name of the hardcoded namespace is test-ns
  3. Within the controller config, there is a secret referenced called keystore. I have to run a number of manual tasks in order to create this secret, listed here: https://github.com/camunda/distribution/issues/254#issuecomment-2192839213

Once these 3 problems are solved, we can incorporate routes in our CI.

Copy link
Member

@aabouzaid aabouzaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hamza-m-masood Let's sync about this PR to ensure it's in the correct shape.

@hamza-m-masood hamza-m-masood force-pushed the openshift-routes-integration-test branch from 1437eaa to a66bcbf Compare October 22, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants