Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AngularJS partials importation, Remove SVG build-time modifications #9454

Merged
merged 5 commits into from
Aug 30, 2024

Conversation

sbrunner
Copy link
Member

@sbrunner sbrunner commented Aug 28, 2024

Resume:

  • Move the SVG icons in JavaScript files.
  • Remove loaders that inline the SVG files.
  • Move AngularJS partials in JavaScript files.
  • Remove RAW loader

See JIRA issue: GSNGEO-12.

See JIRA issue: GSNGEO-13.
Examples
Storybook
API help
API documentation

@sbrunner sbrunner force-pushed the template-GSNGEO-13 branch 4 times, most recently from 4a35090 to d7fadc0 Compare August 28, 2024 12:00
@sbrunner sbrunner force-pushed the template-GSNGEO-13 branch 3 times, most recently from 9efe0fe to c211799 Compare August 28, 2024 14:08
@sbrunner sbrunner changed the title Update AngularJS partials importation Update AngularJS partials importation, Remove SVG build-time modifications Aug 28, 2024
@sbrunner sbrunner force-pushed the template-GSNGEO-13 branch 5 times, most recently from 8f4522f to 8f4567f Compare August 29, 2024 09:49
@sbrunner sbrunner marked this pull request as ready for review August 29, 2024 10:31
Copy link
Member

@ger-benjamin ger-benjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@sbrunner sbrunner merged commit 3c36c32 into master Aug 30, 2024
13 checks passed
@sbrunner sbrunner deleted the template-GSNGEO-13 branch August 30, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants