Fix define_settings method #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 13.0, the method ResConfigSettings.execute() [0] reset odoo env after installing/uninstalling addons, after this, computed fields misbehave (for instance, after a record creation, they would return an empty value or a CacheMiss) In 13.0, we can call set_values() which does what we want, before this version, we have to keep calling execute() (which doesn't have the mentioned issue) because it sets the default values and the groups. [0] https://github.com/odoo/odoo/blob/054d4bc6bc219bcc6b0a64265e8d7e9c7423dbc8/odoo/addons/base/models/res_config.py#L633-L637
simahawk
reviewed
Jan 14, 2020
| # In 13.0, execute calls set_values(), then takes care of | ||
| # install/uninstall. execute() resets the env which breaks | ||
| # computed fields afterwards, so do not call it. | ||
| model.create(values).set_values() |
There was a problem hiding this comment.
I'm not sure if some projects don't rely on it to install modules 🤔
There was a problem hiding this comment.
They shouldn't ;)
And for < 13.0, the behavior doesn't change, so not too much risk I guess. Anyway, it's broken in 13.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 13.0, the method ResConfigSettings.execute() [0] reset odoo env after
installing/uninstalling addons, after this, computed fields misbehave
(for instance, after a record creation, they would return an empty value
or a CacheMiss)
In 13.0, we can call set_values() which does what we want, before this
version, we have to keep calling execute() (which doesn't have the
mentioned issue) because it sets the default values and the groups.
[0] https://github.com/odoo/odoo/blob/054d4bc6bc219bcc6b0a64265e8d7e9c7423dbc8/odoo/addons/base/models/res_config.py#L633-L637