Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add templates for data tables #695

Merged
merged 3 commits into from
Oct 18, 2024
Merged

Add templates for data tables #695

merged 3 commits into from
Oct 18, 2024

Conversation

brynpickering
Copy link
Member

Fixes #676

Reviewer checklist

  • Test(s) added to cover contribution
  • Documentation updated
  • Changelog updated
  • Coverage maintained or improved

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.97%. Comparing base (a9a610e) to head (bf68920).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main     #695    +/-   ##
========================================
  Coverage   95.96%   95.97%            
========================================
  Files          29       29            
  Lines        4039     4048     +9     
  Branches      848      578   -270     
========================================
+ Hits         3876     3885     +9     
  Misses         72       72            
  Partials       91       91            
Files with missing lines Coverage Δ
src/calliope/model.py 96.00% <100.00%> (+0.07%) ⬆️
src/calliope/preprocess/data_tables.py 100.00% <100.00%> (ø)
src/calliope/preprocess/model_data.py 100.00% <100.00%> (ø)
src/calliope/util/tools.py 94.59% <100.00%> (+4.59%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Member

@sjpfenninger sjpfenninger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A great idea. Just some comments on making climb_template_tree() easier to understand.

@brynpickering
Copy link
Member Author

Hopefully fixes all work for you @sjpfenninger !

@brynpickering brynpickering merged commit ed25596 into main Oct 18, 2024
13 checks passed
@brynpickering brynpickering deleted the data-table-templates branch October 18, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data sources and templates
2 participants