Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add gcs capability #9

Merged
merged 1 commit into from
Nov 8, 2023
Merged

add gcs capability #9

merged 1 commit into from
Nov 8, 2023

Conversation

lruizcalico
Copy link
Contributor

Description of your changes

  1. add gcs capability to grad computation
  2. Move borzoi_satg_gene_gpu.py scripts under a new folder so it could be called as a package
  3. Black format the added file

Issue ticket number and link

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation add / update

(If applicable) How has this been tested?

johli
johli approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@johli johli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@lruizcalico lruizcalico merged commit a45fe40 into main Nov 8, 2023
4 checks passed
@lruizcalico lruizcalico deleted the run-composer branch November 8, 2023 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johli johli johli approved these changes

@davek44 davek44 Awaiting requested review from davek44

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lruizcalico @johli