Feat style #39
Open
Feat style #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* main: Fixing state for the index of the highlighted tab. caduandrade#31 Adding test to close/selectedIndex status Fixing test Fixing analysis Drop color theme Adding the newIndex parameter on OnBeforeDropAccept # Conflicts: # lib/src/internal/tabs_area/drop_tab_widget.dart # lib/src/internal/tabs_area/tabs_area_corner.dart # lib/src/tab_widget.dart # lib/src/tabs_area.dart # lib/src/theme/tabs_area_theme_data.dart
|
Hi! Could you format the code with "dart format"? It will reduce the differences. |
|
Could you paste a very simple example code using this new functionality here in the comments? You could use the committed example as a base. |
* main: Fixing state for the index of the highlighted tab. caduandrade#31 Adding test to close/selectedIndex status Fixing test Fixing analysis Drop color theme Adding the newIndex parameter on OnBeforeDropAccept # Conflicts: # example/macos/Runner.xcodeproj/project.pbxproj # example/macos/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme # lib/src/internal/tabs_area/drop_tab_widget.dart # lib/src/internal/tabs_area/tabs_area_corner.dart # lib/src/tab_widget.dart # lib/src/theme/tabs_area_theme_data.dart
|
Function has been added in example |
|
Difference resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1、add custom drop over painter
2、add tab maxWidth
3、add tabs addButton
4、menu theme border/color -> decoration