Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(command): ✨ add Editor prompt type #712

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

JOTSR
Copy link
Contributor

@JOTSR JOTSR commented May 31, 2024

Summary

Add user defined terminal editor prompt type (Editor).

Motivation

Allow full featured terminal (or ui) editor prompt.

Changes

  • Add prompt/editor.ts.

Todo

  • Add validations.
  • Add options (maybe prefered implementer editor, only terminal or visual edito, ...).
  • Implement fully (all methods).
  • Add tests.
  • Add doc.

Maybe choose a better name: "TextEditor", ...

Copy link
Contributor Author

@JOTSR JOTSR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@c4spar Before continuing to work on this feature (tests, improve code, and docs), does this feat right for you ?

@JOTSR JOTSR changed the title feat(command): ✨ add Editor prompt type feat(command): ✨ add Editor prompt type May 31, 2024
@JOTSR JOTSR marked this pull request as draft May 31, 2024 16:37
@JOTSR
Copy link
Contributor Author

JOTSR commented Jun 1, 2024

Demo

image
Vidéo sans titre ‐ Réalisée avec Clipchamp

@c4spar
Copy link
Owner

c4spar commented Jun 2, 2024

Thx @JOTSR, this feature would be very welcome 👍
closes #9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants