Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test add and delete functionality #8

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Test add and delete functionality #8

wants to merge 16 commits into from

Conversation

c3c1l1a
Copy link
Owner

@c3c1l1a c3c1l1a commented Jun 9, 2022

Proposed changes

The aim of this pull request is to test to the todo list checking to add and delete an item.

The following features were added

  • Test using a mock storage object to "imitate" localStorage operations
  • Mocked HTML to test if add/delete functions add or remove exactly one <li> element to/from the list in the DOM.
  • The tests are grouped using the describe() method.

Type of change

  • New feature

Checklist

Copy link

@medaminedev66 medaminedev66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @c3c1l1a and @CrystallineButterfly 😃, 👋,

Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

  • The repo looks professional ✔️
  • There are no linter errors ✔️
  • You have a descriptive PR ✔️
  • The tests run successfully ✔️

Required Changes ♻️

  • It would be preferable if you provide instructions in your README on how users can run the jest tests locally.

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Copy link

@Ismailco Ismailco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Team

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

cr-approve

Highlights

✔️ No linter errors
✔️ All tests passed
✔️ Work documented professionally

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants