-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve buf-ci action and add README and LICENSE #608
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest Buf updates on your PR.
|
emcfarlane
reviewed
Jun 26, 2024
proto/README.md
Outdated
@@ -0,0 +1 @@ | |||
../README.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might not be needed when bufbuild/buf#3112 lands.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I can revert these two when that lands 😄
pkwarren
reviewed
Jun 26, 2024
emcfarlane
reviewed
Jun 26, 2024
emcfarlane
approved these changes
Jun 26, 2024
pkwarren
reviewed
Jun 26, 2024
Co-authored-by: Philip K. Warren <pkwarren@users.noreply.github.com>
pkwarren
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We might have other
LICENSE/README/buf.yaml
files for static config for individual managed modules, we don't want to trigger thebuf-ci.yaml
action when changing those, only when changing something within theproto/*
dir.Add symlinks/content for
LICENSE/README
in the base BSR module.