Merge pull request #37 from brunotot/hotfix-keycloak-dao-client-id-app

chore: hotfix
brunotot · Nov 26, 2024 · 2c44f7c · 2c44f7c
2 parents f51621a + 8fe1d50
commit 2c44f7c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/apps/app-node-express/src/lib/keycloak/KeycloakDao.ts b/apps/app-node-express/src/lib/keycloak/KeycloakDao.ts
@@ -4,15 +4,15 @@ import { env } from "@/server/env";
 export class KeycloakDao {
   private readonly TOKEN_MANAGER: KeycloakTokenManager;
   private readonly ADMIN_API_URL: string;
-
-  public static readonly KC_CLIENT_ID = "9943a0fd-de66-4247-a7b8-c0a94a70b393";
+  private readonly KC_CLIENT_ID: string;
 
   protected ROLES: Record<string, string>;
 
   constructor() {
     const { KEYCLOAK_URL, KEYCLOAK_REALM } = env;
     this.TOKEN_MANAGER = new KeycloakTokenManager();
     this.ADMIN_API_URL = `${KEYCLOAK_URL}/admin/realms/${KEYCLOAK_REALM}`;
+    this.KC_CLIENT_ID = env.KEYCLOAK_APP_CLIENT_ID;
     this.initRoles();
   }
 
@@ -78,7 +78,7 @@ export class KeycloakDao {
 
   private async initRoles() {
     const res = await this.get<{ id: string; name: string }[]>(
-      `/clients/${KeycloakDao.KC_CLIENT_ID}/roles`,
+      `/clients/${this.KC_CLIENT_ID}/roles`,
     );
     this.ROLES = res.reduce(
       (acc, role) => {

diff --git a/apps/app-node-express/src/server/env.ts b/apps/app-node-express/src/server/env.ts
@@ -226,6 +226,8 @@ const ENVIRONMENT_VARS = z.object({
    */
   KEYCLOAK_TOKEN_ENDPOINT: z.string().default("/token").transform(Transform.URL),
 
+  KEYCLOAK_APP_CLIENT_ID: z.string(),
+
   /**
    * Allowed origins for CORS requests.
    * @default "*"