Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle fNS XmitDataAns as a TxAck #561

Closed
wants to merge 1 commit into from
Closed

Handle fNS XmitDataAns as a TxAck #561

wants to merge 1 commit into from

Conversation

conny-andersson
Copy link
Contributor

I made this change to fix issue #555 but I can see now that you did some additional changes to the code and removed the async XmitDataReq.

If you have time to look at this solution, it treats the XmitDataAns as an TxAck and fires that flow. If this is not done, frame-counters are never updated and subsequent downlinks will not be accepted by the end node. I made this async so that the downlink session is saved before TxAck handling is started, similar to how it is handled in fNS.

brocaar added a commit that referenced this pull request Dec 6, 2021
@brocaar
Copy link
Owner

brocaar commented Dec 6, 2021

Thanks @conny-andersson-netmore 👍 I took your code as an example to implement the above commit. Instead of syncing the Go routines using channels, I added this as an extra step to the flow.

If the XmitDataReq fails, this point is never reached and the TxAck is never triggered. If the XmitDataAns succeeds, then the device session is saved before the TxAck is triggered.

@brocaar brocaar closed this Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants