Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made this change to fix issue #555 but I can see now that you did some additional changes to the code and removed the async XmitDataReq.
If you have time to look at this solution, it treats the XmitDataAns as an TxAck and fires that flow. If this is not done, frame-counters are never updated and subsequent downlinks will not be accepted by the end node. I made this async so that the downlink session is saved before TxAck handling is started, similar to how it is handled in fNS.