Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding SvABA annotation to TAG-public #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

MicahR-Y
Copy link
Collaborator

Adding changes that Mo and I have been working on here: https://github.com/broadinstitute/TAG/issues/1693

Copy link
Collaborator

@yueyaog yueyaog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the codes are not very robust. Request changes.

"SomaticRearrangement.Merge_Annotations_Script": "${workspace.merge_annotations_script}",
"SomaticRearrangement.Svaba_Annotate_Rscript": "${workspace.svaba_annotations_script}",
"SomaticRearrangement.annotation_reference_bed": "${workspace.annotation_bed}",
"SomaticRearrangement.configFile": "${workspace.snpEff_config}",
"SomaticRearrangement.control_bam": "gs://gptag/tag_183/SM-CEMHS.bam",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update unmatched normal



command{
Rscript ${merge_annotations_script} ${svaba_vcf} ${snpsift_table} \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Submit this R script to Pull Request

}
}

task snpEffCaller {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need use snpEff here? Is there something more efficient out there?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this WDL and merge the task to the main SVABA WDL

}
runtime {
docker: "us.gcr.io/cromptonlab-001-mt/broadinstitute-gatk"
memory: "2 GB"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to make it flexible

}
}

task intersectAnnotate {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make the commands here less hard-coded

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lots of hard coded things. Better to do it with established tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants