-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul console output #137
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #68 (incidentally)
This PR completely overhauls the console output when Brioche runs builds. Here's a little recording:
(For comparison, here's a recording showing the same build running in the current version of Brioche)
I spent a lot of time iterating on the new output, and it has a few little perks I want to highlight:
JobOutputContents
type. Basically, we keep a buffer that can hold up to 1 MB of output, with special care for partially-written lines (e.g. unbuffered output)Also, I spent some time bringing over some of these changes to the "plain" output format too, where it made sense to do so. Internally, the biggest change to the "plain" format, where we can now reuse the new
JobOutputContents
type to handle partially-written lines (whereas it was entirely separate from the superconsole-based output)