New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some LSP errors from converting between line / column numbers and positions #134

Merged

kylewlacy merged 2 commits into main from fix-some-lsp-errors

Sep 29, 2024

Member

kylewlacy commented Sep 29, 2024

This PR makes some minor tweaks to the LSP that should resolve a few errors and exceptions:

Log warning message when deserializing response from LSP fails (this should help debug future failures)
Prevent Lsp.diagnostic() from returning out-of-bounds line / column numbers causing deserialization error
Catch exceptions from ts.getPositionOfLineAndCharacter()

kylewlacy added 2 commits

September 29, 2024 14:00


          Log a warning if deserializing from LSP fails

c1fdc9c


          Fix LSP error from converting between lines/cols and positions

52ed352

kylewlacy merged commit 70bdb74 into main

5 checks passed

kylewlacy deleted the fix-some-lsp-errors branch

September 29, 2024 23:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet