Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --locked flag for several subcommands #133

Merged
merged 5 commits into from
Sep 29, 2024
Merged

Add --locked flag for several subcommands #133

merged 5 commits into from
Sep 29, 2024

Conversation

kylewlacy
Copy link
Member

@kylewlacy kylewlacy commented Sep 29, 2024

This PR updates several subcommands with a new --locked flag, namely build, check, run, and install. When used, the command will fail unless the lockfiles are up-to-date.

The main motivation for this change is for use in CI, such as in the brioche-packages repo (see brioche-dev/brioche-packages#111 for an example of a PR that got through with an out-of-date lockfile)

Currently, the error messages leave a lot to be desired... here's an example error:

Error occurred with project './packages/hello_world': project load errors: [FailedToLoadDependency { name: "std", cause: "hash for download 'https://example.com/' not found in lockfile" }]

@kylewlacy kylewlacy merged commit 441ff4c into main Sep 29, 2024
5 checks passed
@kylewlacy kylewlacy deleted the locked-flag branch September 29, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant