Restore deno_core
update and fix stack frames
#100
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restores the
deno_core
updates from #93 (which was originally reverted in #99), along with a fix to the how stack frames are resolved in scriptsThe discussion in #98 has more context, but to summarize:
deno_core
v0.215.0, the functionDeno.core.prepareStackTrace
was no longer being set and instead defined directly onError.prepareStackTrace
Error.prepareStackTrace
was wrong, and was just clearing out theprepareStackTrace
function insteadBrioche.glob
, thestd
package uses error stack traces to determine which project to resolve the glob from. This broke due to (2)The fix was then to just remove the line where we were setting
Error.prepareStackTrace
. For some reason, this also caused a panic that was resolved by markingop_brioche_stack_frames_from_exception
as re-entrant (according to thedeno_core
docs, this is needed whenever one op calls another op)This PR also adds a new unit test to validate
op_brioche_stack_frames_from_exception
(and, indirectly,Error.prepareStackTrace
).