feat: add validate multiple license files #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelkoniecznybh
changed the title
pawelkoniecznybh
changed the base branch from
handle-needsVerification-v2
to
release-v2.0.0
pawelkoniecznybh
changed the title
bh-pwalen
reviewed
Nov 25, 2024
bh-pwalen
reviewed
Nov 25, 2024
Lukasz-pluszczewski
requested changes
Nov 25, 2024
* feat: add e2e and unit test for finding license in file * refactor: change test names in e2e * fix: lint * feat: add build script in ci
Lukasz-pluszczewski
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual test cases:
LICENSE-MIT LICENSE-WRONG -> We found some, but not all licenses for package
LICENSE-WRONG -> We’ve found a license file, but no matching licenses in
LICENSE-MIT -> OK
LICENSE-MIT LICENSE-ISC -> OK
LICENSE-MIT LICENSE-AAL -> Not all licenses are whitelisted
without --verbose flag
with --verbose flag
