Skip to content
This repository has been archived by the owner on Jan 5, 2024. It is now read-only.

Add visibility flag to remove listing from napari hub #182

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

adamltyson
Copy link
Member

I think this should work (it works on other repos). I'll give it a try on this plugin then repeat on the others if it works.

@adamltyson adamltyson requested a review from a team January 4, 2024 11:09
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c75f317) 95.37% compared to head (bff956a) 95.37%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #182   +/-   ##
=======================================
  Coverage   95.37%   95.37%           
=======================================
  Files          17       17           
  Lines         800      800           
=======================================
  Hits          763      763           
  Misses         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@alessandrofelder alessandrofelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool - I'll merge. Presumably this will have an effect when we make the final release?

@alessandrofelder alessandrofelder merged commit 690abbd into main Jan 4, 2024
13 checks passed
@alessandrofelder alessandrofelder deleted the hide-napari branch January 4, 2024 11:26
@adamltyson
Copy link
Member Author

I think we've made the final release (just forgot to do this). However, I think it doesn't matter. I think the napari hub looks at the GitHub source (otherwise it would have to download from PyPI, extract, and inspect).

@adamltyson
Copy link
Member Author

Ah, I was wrong. The info is fetched from the source, but only upon release or manual trigger: https://www.napari-hub.org/faq

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants