Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brainrender napari > Brainrender #73

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Conversation

alessandrofelder
Copy link
Member

@alessandrofelder alessandrofelder commented Aug 23, 2023

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
It is unnecessary to specify that the widget is a napari widget if the widget is inside napari anyway.

What does this PR do?
Changes the display names of the brainrender widget.

References

Closes #71

How has this PR been tested?

Manual testing and looking at the GUI.

Is this a breaking change?

Nope

Does this PR require an update to the documentation?

Nope

Checklist:

  • The code has been tested locally
  • [n/a] Tests have been added to cover all new functionality (unit & integration)
  • [n/a] The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@alessandrofelder alessandrofelder self-assigned this Aug 23, 2023
@alessandrofelder alessandrofelder added the enhancement New feature or request label Aug 23, 2023
@alessandrofelder alessandrofelder changed the title no need for napari for names displayed inside napari Brainrender napari > Brainrender Aug 23, 2023
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7121f2d) 96.72% compared to head (9a61363) 96.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #73   +/-   ##
=======================================
  Coverage   96.72%   96.72%           
=======================================
  Files           7        7           
  Lines         305      305           
=======================================
  Hits          295      295           
  Misses         10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alessandrofelder alessandrofelder marked this pull request as ready for review August 23, 2023 15:46
@alessandrofelder
Copy link
Member Author

Windows tests were taking too long here and elsewhere, so opened #74

@adamltyson adamltyson merged commit fb9d764 into main Aug 23, 2023
8 of 11 checks passed
@alessandrofelder alessandrofelder deleted the fix-widget-display-name branch August 24, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Inside napari, the plugin should be named "brainrender"
2 participants