Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e login test #609

Merged
merged 21 commits into from
Jan 11, 2024
Merged

e2e login test #609

merged 21 commits into from
Jan 11, 2024

Conversation

emmacode
Copy link
Contributor

@emmacode emmacode commented Oct 10, 2023

e2e login test
Closes #51

@emmacode
Copy link
Contributor Author

@devkiran
Please I need your review and below is what I'm trying to do

  1. In docker-compose.yml I created a test database to use for the tests
  2. In logn.spec.ts when the Sign in button is clicked. It is not redirecting to the dashboard. When the button is clicked the loading is still true therefore not navigating to the dashboard. This error as well [Failed to load resource: the server responded with a status of 401 (Unauthorized)]

Screenshot of screen
Screenshot

@devkiran
Copy link
Contributor

Thanks @emmacode for the PR. Let's review this and get back to you soon.

yarn.lock Outdated Show resolved Hide resolved
tests/e2e/auth/login.spec.ts Outdated Show resolved Hide resolved
Copy link
Member

@niwsa niwsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emmacode Left a few comments. Let me know in case you have any queries.

@emmacode emmacode requested a review from niwsa October 26, 2023 15:15
@emmacode
Copy link
Contributor Author

@niwsa I have addressed the requested changes
Below is the issue I had

Please I need your review

I have removed the manual process and used the /auth/join flow as instructed. However, after creating an account and trying to test for the login, the Sign In button is not redirecting to the dashboard. When the button is clicked the loading is still true therefore not navigating to the dashboard. This error as well [Failed to load resource: the server responded with a status of 401 (Unauthorized)]

Screenshot of screen
Screenshot

emmacode and others added 9 commits October 26, 2023 17:29
Signed-off-by: Kiran K <kiran@boxyhq.com>
Signed-off-by: Kiran K <mailtokirankk@gmail.com>
Signed-off-by: Kiran K <kiran@boxyhq.com>
Signed-off-by: Kiran K <kiran@boxyhq.com>
Signed-off-by: Kiran K <kiran@boxyhq.com>
@devkiran
Copy link
Contributor

@emmacode Can you run and check if you have the same issue now? I have made some changes.

@devkiran devkiran requested a review from a team November 20, 2023 10:31
@deepakprabhakara deepakprabhakara merged commit 482d674 into boxyhq:main Jan 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[e2e test] Login to the SaaS starter kit UI
5 participants