Bugfix: flaky for nose could raise a KeyError at the end of a failed …

…rerun test.

HISTORY.rst

@@ -3,6 +3,14 @@
 Release History
 ---------------
 
+
+2.1.0 (2015-05-05)
+++++++++++++++++++
+
+**Bugfixes**
+
+- Flaky will no longer raise a KeyError for failed flaky tests.
+
 2.1.0 (2015-05-05)
 ++++++++++++++++++
 

flaky/flaky_nose_plugin.py

@@ -80,7 +80,7 @@ def stopTest(self, test):
         # pylint:disable=invalid-name
         if self._test_status[test]:
             test.run(self._flaky_result)
-        del self._test_status[test]
+        self._test_status.pop(test, None)
 
     def _rerun_test(self, test):
         """

setup.py

@@ -27,7 +27,7 @@ def main():
     base_dir = dirname(__file__)
     setup(
         name='flaky',
-        version='2.1.0',
+        version='2.1.1',
         description='Plugin for nose or py.test that automatically reruns flaky tests.',
         long_description=open(join(base_dir, 'README.rst')).read(),
         author='Box',

test/test_example.py

@@ -5,6 +5,8 @@
 # This is an end-to-end example of the flaky package in action. Consider it
 # a live tutorial, showing the various features in action.
 
+from genty import genty, genty_dataset
+
 from flaky import flaky
 from test.base_test_case import TestCase, expectedFailure, skip
 
@@ -85,3 +87,15 @@ def test_flaky_function(param=[]):
     param_length = len(param)
     param.append(None)
     assert param_length == 1
+
+
+@genty
+class ExampleFlakyTestsWithUnicodeTestNames(ExampleFlakyTests):
+    @genty_dataset('ascii name', 'ńőń ȁŝćȉȉ ŝƭȕƒƒ')
+    def test_non_flaky_thing(self, message):
+        # pylint:disable=unused-argument
+        self._threshold += 1
+        if self._threshold < 1:
+            raise Exception("Threshold is not high enough: {0} vs {1}.".format(
+                self._threshold, 1),
+            )

test/test_flaky_plugin.py

@@ -2,6 +2,7 @@
 
 from __future__ import unicode_literals
 from genty import genty, genty_dataset
+from io import StringIO
 from flaky._flaky_plugin import _FlakyPlugin
 from flaky.names import FlakyNames
 from test.base_test_case import TestCase
@@ -21,7 +22,7 @@ def test_flaky_plugin_handles_non_ascii_byte_string_in_exception(self):
         self._flaky_plugin._log_test_failure(
             mock_method_name,
             (ValueError.__name__, mock_exception, ''),
-            mock_message
+            mock_message,
         )
 
     @genty_dataset(
@@ -56,3 +57,11 @@ def test_flaky_plugin_identifies_failure(
             self._flaky_plugin._has_flaky_test_failed(flaky),
             expect_fail,
         )
+
+    @genty_dataset('ascii stuff', 'ńőń ȁŝćȉȉ ŝƭȕƒƒ')
+    def test_write_unicode_to_stream(self, message):
+        stream = StringIO()
+        stream.write('ascii stuff')
+        # pylint:disable=protected-access
+        self._flaky_plugin._stream.write(message)
+        self._flaky_plugin._add_flaky_report(stream)