Remove superfluous check from null_ptr_check #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
null_ptr_check()
function checks thatdev.inft_ptr
is not NULL, however, nowhere in the code it this pointer used.Indeed
dev.inf_ptr
is only used in user defined functions:read
,write
anddelay_us
... hence if it is up to the user to use the pointer it should be up to the user to check it.In the current state of things if the user doesn't want to use the pointer he would still have to assign it a value in order to pass the init, which is, imo, a bad practice.
Thus removing the check makes sense.