Avoid overread in headerless FIFO example #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overreading the FIFO doesn't provide any value in this example. Furthermore, bmi2_extract_accel and other extract functions rely on the fifoframe.length parameter to be correct in order to adjust the read length (i.e. in parse_fifo_accel_len, if the read would go beyond the end of the FIFO, only the remaining available bytes are extracted).
This is not an issue in this exact example because the BMI2_FIFO_ACCEL_FRAME_COUNT define matches the number of samples at the watermark level. But generally, the definition of the accel_length length parameter of function bmi2_extract_accel as an in/out parameter indicates that the bmi2_extract_accel function can return a lower number of accel samples than the accel_length requests (and it does set the accel_length the the true number of samples extracted before returning). This can only function if the fifoframe.length parameter does not reach into overread 0x8000 data.
Equivalent changes may be necessary for gyr, aux and other examples.