Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid overread in headerless FIFO example #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

akandi
Copy link

@akandi akandi commented Nov 3, 2021

Overreading the FIFO doesn't provide any value in this example. Furthermore, bmi2_extract_accel and other extract functions rely on the fifoframe.length parameter to be correct in order to adjust the read length (i.e. in parse_fifo_accel_len, if the read would go beyond the end of the FIFO, only the remaining available bytes are extracted).

This is not an issue in this exact example because the BMI2_FIFO_ACCEL_FRAME_COUNT define matches the number of samples at the watermark level. But generally, the definition of the accel_length length parameter of function bmi2_extract_accel as an in/out parameter indicates that the bmi2_extract_accel function can return a lower number of accel samples than the accel_length requests (and it does set the accel_length the the true number of samples extracted before returning). This can only function if the fifoframe.length parameter does not reach into overread 0x8000 data.

Equivalent changes may be necessary for gyr, aux and other examples.

Overreading the FIFO doesn't provide any value in this example. Furthermore, bmi2_extract_accel and other extract functions rely on the fifoframe.length parameter to be correct in order to adjust the read length (i.e. in parse_fifo_accel_len, if the read would go beyond the end of the FIFO, only the remaining available bytes are extracted).

This is not an issue in this exact example because the BMI2_FIFO_ACCEL_FRAME_COUNT define matches the number of samples at the watermark level. But generally, the definition of the accel_length length parameter of function bmi2_extract_accel as an in/out parameter indicates that the bmi2_extract_accel function can return a lower number of accel samples than the accel_length requests (and it does set the accel_length the the true number of samples extracted before returning). This can only function if the fifoframe.length parameter does not reach into overread 0x8000 data.

Equivalent changes may be necessary for gyr, aux and other examples.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant