Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add relative rotation metric on Rotation Averaging module #731

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Add relative rotation metric on Rotation Averaging module #731

wants to merge 8 commits into from

Conversation

johnwlambert
Copy link
Collaborator

No description provided.

akshay-krishnan
akshay-krishnan approved these changes Oct 10, 2023
View reviewed changes
gtsfm/utils/geometry_comparisons.py Outdated Show resolved Hide resolved
gtsfm/utils/metrics.py Outdated Show resolved Hide resolved
@akshay-krishnan
Copy link
Collaborator

sounds good. feel free to merge.
Just curious, are we supposed to read this metric as a measure of noise in the measurements or the estimate error? Do we already have a metric where we do this, but using ground truth "measurements"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshay-krishnan akshay-krishnan akshay-krishnan approved these changes

@ayushbaid ayushbaid Awaiting requested review from ayushbaid

@travisdriver travisdriver Awaiting requested review from travisdriver

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnwlambert @akshay-krishnan