refactoring and simplifying #6
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improvements have been made to avoid code duplication, improve readability and simplify logic:
|
thanks for your work! I have the feeling this script already is kind of messy, and has quite some edge cases not solved, like wrong input args. |
Bash gets messy as the code grows, maybe we can port it to Python or leave it as it is. It seems like upstream won't solve this COPR problem in Ostree anytime soon, unfortunately |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made the script more portable using
env bashand added colors to the echos. This PR will be in draft for now to analyze if it is good or needs some changes