Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(WIP)fix: replace light relay with full relay contracts. #301

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

(WIP)fix: replace light relay with full relay contracts. #301

wants to merge 1 commit into from

Conversation

nakul1010
Copy link
Contributor

Closes #287

@nakul1010 nakul1010 self-assigned this Jul 31, 2024
@vercel Vercel
Copy link

vercel bot commented Jul 31, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bob ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 9:19am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 31, 2024

⚠️ No Changeset found

Latest commit: d15f851

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nakul1010 nakul1010 marked this pull request as draft July 31, 2024 09:17
gregdhill
gregdhill requested changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@gregdhill gregdhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to fully replace which relay can be used, should still be possible to use the LightRelay with these utils.

src/relay/TestFullRelay.sol
/// be possible to validate blocks with the real LightRelay.
/// @dev Notice that TestLightRelay is derived from LightRelay so that the two
/// contracts have the same API and correct bindings can be generated.
contract TestFullRelay is FullRelay {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure why we need this contract, could you explain?

@Brendabuena2 Brendabuena2 mentioned this pull request Sep 10, 2024
Closed
@bob-collective bob-collective deleted a comment from Brendabuena2 Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregdhill gregdhill gregdhill requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@nakul1010 nakul1010

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate full relay with existing utils
2 participants
@nakul1010 @gregdhill