Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate full relay with existing utils #287

Open
gregdhill opened this issue Jul 11, 2024 · 1 comment · May be fixed by #301
Open

Integrate full relay with existing utils #287

gregdhill opened this issue Jul 11, 2024 · 1 comment · May be fixed by #301
Assignees
Labels
prio:medium Clear benefit of this feature. Will be worked on unless there are high or critical priority tasks.

Comments

@gregdhill
Copy link
Contributor

gregdhill commented Jul 11, 2024

I also think for next steps it could be good to integrate this code with BitcoinTx.sol and WitnessTx.sol (specifically validateWitnessProof) since I think that will let projects do some interesting things with Ordinals in the future.

Originally posted by @gregdhill in #273 (review)

Depends on #285

@nud3l nud3l added this to Backlog Jul 11, 2024
@github-project-automation github-project-automation bot moved this to New 🆕 in Backlog Jul 11, 2024
@gregdhill gregdhill added the prio:medium Clear benefit of this feature. Will be worked on unless there are high or critical priority tasks. label Jul 11, 2024
@gregdhill gregdhill moved this from New 🆕 to Todo ⏳ in Backlog Jul 11, 2024
@nakul1010
Copy link
Contributor

Using FullRelay instead of LightRelay in BitcoinTx.sol and WitnessTx.sol will break all the marketplace contracts, as they depend on LightRelay. Would you prefer to:

  • Keep separate utility files, such as:
    • BitcoinFullRelayTx.sol & WitnessFullRelayTx.sol
    • BitcoinLightRelayTx.sol & WitnessLightRelayTx.sol
    • This approach avoids breaking the marketplace contracts.

OR

  • Use FullRelay in BitcoinTx.sol and WitnessTx.sol and update the marketplace contracts to use FullRelay.

@nakul1010 nakul1010 assigned nakul1010 and unassigned ferencdg Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio:medium Clear benefit of this feature. Will be worked on unless there are high or critical priority tasks.
Projects
Status: Todo ⏳
Development

Successfully merging a pull request may close this issue.

3 participants