Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: publish ChainUndelegate event and ledger sig issue #1015

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

j75689
Copy link
Contributor

@j75689 j75689 commented Mar 1, 2024

Description

  1. fix: publish ChainUndelegate event
  2. fix: ledger sig conversion

Rationale

related to: bnb-chain/bnc-cosmos-sdk#389, bnb-chain/bnc-cosmos-sdk#390

Example

n/a

Changes

Notable changes:

  • event

Preflight checks

  • build passed (make build)
  • tests passed (make test)
  • integration tests passed (make integration_test)
  • manual transaction test passed (cli invoke)

Already reviewed by

n/a

Related issues

n/a

@j75689
Copy link
Contributor Author

j75689 commented Mar 1, 2024

Will Update go.mod after bnc-cosmos-sdk@v0.26.9 release

@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.87%. Comparing base (3c72c85) to head (b7eb215).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1015      +/-   ##
==========================================
+ Coverage   47.85%   47.87%   +0.01%     
==========================================
  Files         127      127              
  Lines       12822    12822              
==========================================
+ Hits         6136     6138       +2     
+ Misses       6252     6249       -3     
- Partials      434      435       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@j75689 j75689 changed the title fix: publish ChainUndelegate event fix: publish ChainUndelegate event and ledger issue Mar 5, 2024
@j75689 j75689 changed the title fix: publish ChainUndelegate event and ledger issue fix: publish ChainUndelegate event and ledger sig issue Mar 5, 2024
@unclezoro unclezoro merged commit 911507e into master Mar 5, 2024
8 checks passed
Copy link

@colorado392 colorado392 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants