Add introspection of the errors that make up NotConnected (#649)

bluesky · Nov 14, 2024 · 3a12838 · 3a12838
1 parent bc153ea
commit 3a12838
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/src/ophyd_async/core/_utils.py b/src/ophyd_async/core/_utils.py
@@ -62,6 +62,13 @@ def __init__(self, errors: ErrorText):
 
         self._errors = errors
 
+    @property
+    def sub_errors(self) -> Mapping[str, Exception]:
+        if isinstance(self._errors, dict):
+            return self._errors.copy()
+        else:
+            return {}
+
     def _format_sub_errors(self, name: str, error: Exception, indent="") -> str:
         if isinstance(error, NotConnected):
             error_txt = ":" + error.format_error_string(indent + self._indent_width)

diff --git a/tests/core/test_utils.py b/tests/core/test_utils.py
@@ -197,6 +197,14 @@ async def test_error_handling_device_collector_mock():
     assert str(expected_output) == str(e.value)
 
 
+def test_introspecting_sub_errors():
+    sub_error1 = NotConnected("bad")
+    assert sub_error1.sub_errors == {}
+    sub_error2 = ValueError("very bad")
+    error = NotConnected({"child1": sub_error1, "child2": sub_error2})
+    assert error.sub_errors == {"child1": sub_error1, "child2": sub_error2}
+
+
 async def test_error_handling_device_collector(caplog):
     caplog.set_level(10)
     with pytest.raises(NotConnected) as e: