Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove views from public Session data (again) #4375

Merged
merged 3 commits into from
Sep 29, 2024

Conversation

Kosai106
Copy link
Contributor

@Kosai106 Kosai106 commented Sep 22, 2024

Closes: #3870

What are the changes and their implications?

The views property was removed at v2.0.0-beta.11 but seemingly accidentally added back again in a later version. If this wasn't a mistake, at the very least the use for it should be documented.

Bug Checklist

  • Changeset added (run pnpm changeset in the root directory)
  • Integration test added (see test docs if needed)

Copy link

changeset-bot bot commented Sep 22, 2024

🦋 Changeset detected

Latest commit: 7182f31

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@blitzjs/generator Patch
blitz Patch
@blitzjs/codemod Patch
next-blitz-auth Patch
@blitzjs/auth Patch
@blitzjs/next Patch
@blitzjs/rpc Patch
@blitzjs/config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@siddhsuresh siddhsuresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! yeah it was not intentional, thanks for catching this

@kodiakhq kodiakhq bot merged commit 2711291 into blitz-js:main Sep 29, 2024
29 checks passed
@Kosai106 Kosai106 deleted the chore/session-views--again branch September 29, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New app template incorrectly has views field in session public data
3 participants