Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conditionally republish video on resume #388

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

luukschipperheyn
Copy link
Contributor

When app returns from background, video should only be republished if it was published before.
Unconditionally publishing video upon returning to the app can be unwanted behavior for apps that need local video to be unpublished.

Copy link
Collaborator

@slycoder slycoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, this seems like a good fix but the video gets published by default in onConnected so you'll need to set isLocalVideoPublished there as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants