Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SDK_VERSION not echoing properly #24

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

coroiu
Copy link
Contributor

@coroiu coroiu commented Nov 4, 2024

๐ŸŽŸ๏ธ Tracking

๐Ÿ“” Objective

We were not properly exporting the variable in the workflow, which caused the echo to output an empty string

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 62.85%. Comparing base (e2946ce) to head (7579f9f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #24   +/-   ##
=======================================
  Coverage   62.85%   62.85%           
=======================================
  Files         179      179           
  Lines       12688    12688           
=======================================
  Hits         7975     7975           
  Misses       4713     4713           

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@coroiu coroiu force-pushed the ps/fix-sdk-version-not-echoing-properly branch from b2dba9d to 7579f9f Compare November 4, 2024 13:05
@coroiu coroiu requested a review from Hinton November 4, 2024 13:06
@coroiu coroiu merged commit edee180 into main Nov 4, 2024
39 checks passed
@coroiu coroiu deleted the ps/fix-sdk-version-not-echoing-properly branch November 4, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants