-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement credit deal auto-repayment feature #2735
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that some tests are closer to overflow
to get around MinGW build "string table overflow" issue
abitmore
force-pushed
the
pr-2595-credit-auto-repay
branch
from
March 23, 2023 22:20
f69da5a
to
d069614
Compare
Remove SonarCloud cache and threads configuration as it is now by default
Remove SonarCloud cache and threads configuration as it is now by default
for better coverage reporting, including branch coverage
Type "long" is not reflected in macOS, so avoid using it implicitly in tests
Use gcovr to process code coverage data
…6-2-x Update sonar.projectVersion to 6.2.x
For branch coverage, exclude branches that the compiler generates for exception handling, to generate more "sensible" coverage reports.
Update code coverage report settings in sonar-scan overflow
Resolved conflicts: - sonar-project.properties
Kudos, SonarCloud Quality Gate passed! |
17 tasks
This was referenced Jun 24, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #2595.
Changes:
Add
enum class credit_deal_auto_repayment_type
Update type of
extensions
field ofcredit_offer_accept_operation
struct, add anauto_repay
field inside, so that accounts can decide whether and how to automatically repay when accepting a credit offerNew operation:
credit_deal_update_operation
, so that credit deal owners can change whether or how to automatically repayoperation_type
=76
1 BTS
Rename all
fee_parameters_type
in the codebase tofee_params_t
to get around the "string table overflow" issue in MinGW build