Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo behavior #629

Merged
merged 8 commits into from
Nov 28, 2024
Merged

Demo behavior #629

merged 8 commits into from
Nov 28, 2024

Conversation

Flova
Copy link
Member

@Flova Flova commented Nov 27, 2024

Summary

Adds a simplified behavior that works without a field and localization. Mainly fokussed on external demos e.g. at ITCS or University events.

This is not intended for in game use.

It doesn't listen to the game controller and just walks to the nearest ball and kicks it.

Proposed changes

  • Add simplified dsd file
  • Fix ball close target, so we always approach the ball at the closest angle (no need to aim for the goal)
  • Add a launch file

Related issues

I think we had one, but I am unable to find it.

Checklist

  • Run colcon build
  • Write documentation
  • Test on your machine
  • Test on the robot
  • Create issues for future work
  • Triage this PR and label it

@Flova Flova added enhancement New feature or request behavior labels Nov 27, 2024
@Flova Flova self-assigned this Nov 27, 2024
@Flova Flova marked this pull request as ready for review November 27, 2024 21:18
@Flova
Copy link
Member Author

Flova commented Nov 27, 2024

We tested this, but the test was rushed and Donna had hardware issues. So I would recommend a more thorough test in the near future.

@Flova
Copy link
Member Author

Flova commented Nov 28, 2024

Today we have done some proper testing and it LGTM

@Flova Flova merged commit bd5c859 into main Nov 28, 2024
2 checks passed
@Flova Flova deleted the feature/demo_behavior branch November 28, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants