Jazzy migration #628
Draft
Jazzy migration #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starting from `~` instead of using the whole path
to prevent issues when interacting with the repository both from within the container and outside the container, due to permissions not being correct
in `Dockerfile`, because the `updateRemoteUserUID` setting of the devcontainer does not change the `GID` of the `containerUser` dynamically to the one of the host user if the group exists in the container already microsoft/vscode-remote-release#2402. In our case the `containerUser` is set to `bitbots`, because it automatically uses the last `USER` instruction from the `Dockerfile` and the `remoteUser` inherits from `containerUser`. For reference see: microsoft/vscode-remote-release#1155
|
TODO: Fix cppformat in Jazzy |
Flova
commented
Nov 24, 2024
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| [](https://github.com/bit-bots/bitbots_main/actions/workflows/ci.yml) | |||
| [](https://github.com/bit-bots/bitbots_main/actions/workflows/pre-commit.yml) | |||
| [](https://docs.ros.org/en/iron/index.html) | |||
| [](https://docs.ros.org/en/jazzy/index.html) | |||
There was a problem hiding this comment.
Thanks for also changing the color :D
|
The CI seems to fail due to floating point errors in the team_communication. |
as with upgrade to jazzy or packages floating point handling seems to have changed slightly
|
I've adjusted the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.