Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy tool improvements #223

Merged
merged 15 commits into from
Feb 7, 2024
Merged

Deploy tool improvements #223

merged 15 commits into from
Feb 7, 2024

Conversation

jaagut
Copy link
Member

@jaagut jaagut commented Jan 23, 2024 •
edited
Loading

Summary

This PR introduces several improvements to the deployment tool.

Proposed changes

  • Improve error logs for connection issues
  • Replacing Target class with simple IP address string
  • Set Connection.original_host to the true hostname of the remote system for better logging
  • The install task now also upgrades the system with apt and pip and installs basler drivers
  • Small README formatting fixes

Related issues

Checklist

  • Run colcon build
  • Write documentation
  • Create issues for future work
  • Test on your machine
  • Test on the robot
  • This PR is on our Software project board

@jaagut jaagut self-assigned this Jan 23, 2024
Base automatically changed from monorepo to main January 23, 2024 20:25
Flova pushed a commit that referenced this pull request Jan 23, 2024
@timonegk
Merge pull request #223 from bit-bots/feathure/rosbag_record_python_l…
79d18ef 
…aunch

Add rosbag record files in python
@jaagut jaagut changed the title Deploy tool improvments Deploy tool improvements Jan 25, 2024
@jaagut jaagut marked this pull request as ready for review January 25, 2024 22:30
@jaagut jaagut requested a review from Flova January 25, 2024 22:30
@jaagut jaagut marked this pull request as draft January 26, 2024 18:19
@Flova Flova mentioned this pull request Feb 7, 2024
Closed
6 tasks
@Flova Flova marked this pull request as ready for review February 7, 2024 15:10
@Flova Flova merged commit bb7b2f5 into main Feb 7, 2024
2 checks passed
@Flova Flova deleted the fix/deploy branch February 7, 2024 15:42
@jaagut jaagut mentioned this pull request Feb 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flova Flova Flova approved these changes

Assignees

@jaagut jaagut

Labels
None yet
Projects
Software
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaagut @Flova