Skip to content
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

Cleanup behavior repo #334

Merged
merged 18 commits into from
Nov 14, 2023
Merged

Cleanup behavior repo #334

merged 18 commits into from
Nov 14, 2023

Conversation

Flova
Copy link
Member

@Flova Flova commented Aug 11, 2023

Proposed changes

  • Use ros2 NumPy for more conversions
  • Remove unused features
  • Remove localization check as it was useless during the worldcup
  • Use bitbots_utils features
  • Move head mover to motion
  • Use enum for ball approach types
  • Fix missing path planning cancelation
  • Directly initialize publishers
  • Remove unused ci files
  • Rename blackboard capsule to misc capsule
  • Things to their related capsules

Related PRs

#334
bit-bots/bitbots_motion#414
bit-bots/bitbots_navigation#201
bit-bots/bitbots_lowlevel#136
bit-bots/bitbots_misc#237
bit-bots/udp_bridge#26
bit-bots/humanoid_league_misc#139
bit-bots/wolfgang_robot#280
bit-bots/bitbots_main#207

@jaagut
Copy link
Member

jaagut commented Aug 31, 2023

Please have a look at bit-bots/bitbots_main#282

@jaagut jaagut marked this pull request as draft September 14, 2023 17:16
@Flova Flova marked this pull request as ready for review September 27, 2023 21:07
@Flova Flova requested a review from jaagut November 2, 2023 18:57
# send special command to walking to stop it
msg = Twist()
msg.angular.x = -1.0
self.direct_cmd_vel_pub.publish(msg)

def calculate_time_to_ball(self):
"""
Calculates the time to ball and saves it in the team data capsule.
"""
# only send new request if previous request is finished or first update
# also verify that the ball and the localization are reasonably recent/accurate
if self._blackboard.world_model.ball_has_been_seen() and \
self._blackboard.world_model.localization_precision_in_threshold():
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo don't check that

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be done in a different changeset. @Flova please create an issue.

Copy link
Member

@jaagut jaagut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We decided to merge this, even if not completely reviewed yet, to enable progress in other parts of our software. Tests did not show regressions.

@Flova Flova merged commit 71b7975 into master Nov 14, 2023
@Flova Flova deleted the cleanup/behavior_repo branch November 14, 2023 18:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants