This repository has been archived by the owner on Jan 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 11, 2023
Merged
This was referenced Aug 11, 2023
Please have a look at bit-bots/bitbots_main#282 |
jaagut
reviewed
Oct 26, 2023
…se possible return types.
Flova
commented
Nov 9, 2023
# send special command to walking to stop it | ||
msg = Twist() | ||
msg.angular.x = -1.0 | ||
self.direct_cmd_vel_pub.publish(msg) | ||
|
||
def calculate_time_to_ball(self): | ||
""" | ||
Calculates the time to ball and saves it in the team data capsule. | ||
""" | ||
# only send new request if previous request is finished or first update | ||
# also verify that the ball and the localization are reasonably recent/accurate | ||
if self._blackboard.world_model.ball_has_been_seen() and \ | ||
self._blackboard.world_model.localization_precision_in_threshold(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo don't check that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be done in a different changeset. @Flova please create an issue.
jaagut
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We decided to merge this, even if not completely reviewed yet, to enable progress in other parts of our software. Tests did not show regressions.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related PRs
#334
bit-bots/bitbots_motion#414
bit-bots/bitbots_navigation#201
bit-bots/bitbots_lowlevel#136
bit-bots/bitbots_misc#237
bit-bots/udp_bridge#26
bit-bots/humanoid_league_misc#139
bit-bots/wolfgang_robot#280
bit-bots/bitbots_main#207