This repository has been archived by the owner on Jan 23, 2024. It is now read-only.
Refactor/world model capsule #301
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
val-ba
reviewed
Apr 20, 2023
Flova
reviewed
Apr 24, 2023
| @@ -49,3 +51,4 @@ def __init__(self, node: Node): | |||
| self.head_capsule = HeadCapsule(self) | |||
| self.world_model = WorldModelCapsule(self) | |||
| self.costmap = CostmapCapsule(self) | |||
| self.team_data = TeamDataCapsule(node) | |||
There was a problem hiding this comment.
This has been added, such that the head behavior can also look at the teammate ball directly. This is a behavior change and needs testing. If we don't want to do this, we can simply remove this line.
bitbots_blackboard/bitbots_blackboard/capsules/team_data_capsule.py
Outdated
Show resolved
Hide resolved
bitbots_blackboard/bitbots_blackboard/capsules/team_data_capsule.py
Outdated
Show resolved
Hide resolved
bitbots_blackboard/bitbots_blackboard/capsules/team_data_capsule.py
Outdated
Show resolved
Hide resolved
val-ba
approved these changes
May 24, 2023
|
This PR is still a draft and needs extensive testing imo.. |
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
get_best_ballforget_ballRelated issues
#300
#297
Necessary checks
catkin buildNeeds a lot of testing!