fix: rename zh_hans to zh_CN #2058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chrome onlys seems to recognize zh_CN and in my testing zh_CN works in Firefox too so let's use that. Safari doesn't seem to handle subtags correctly so this still won't work there. See: - https://forums.developer.apple.com/forums/thread/762697 - adobe/helix-sidekick-extension#721 Fixes #2051 for Chrome at least.
birtles
force-pushed
the
fix-chinese-locale
branch
from
5fb2b35
to
e9b3c1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both Chrome and Safari seem only to recognize zh_CN and in my testing
zh_CN works in Firefox too so let's use that.
Fixes #2051.