Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving settings to the Web UI #350

Merged
merged 7 commits into from
Nov 25, 2024
Merged

Moving settings to the Web UI #350

merged 7 commits into from
Nov 25, 2024

Conversation

Trainbird
Copy link
Contributor

Transferring defines from settings.h to be manageable on the Web UI:

  • PLAY_MONO_SPEAKER
  • SAVE_PLAYPOS_BEFORE_SHUTDOWN
  • SAVE_PLAYPOS_WHEN_RFID_CHANGE
  • SAVE_PLAYPOS_WHEN_RFID_CHANGE
  • USE_LAST_VOLUME_AFTER_REBOOT
  • VOLUMECURVE

fabian added 3 commits November 6, 2024 16:31
Transferring defines from settings.h to be manageable on the Web UI:
5691cf1 
* PLAY_MONO_SPEAKER
* SAVE_PLAYPOS_BEFORE_SHUTDOWN
* SAVE_PLAYPOS_WHEN_RFID_CHANGE
* SAVE_PLAYPOS_WHEN_RFID_CHANGE
* USE_LAST_VOLUME_AFTER_REBOOT
* VOLUMECURVE
clang and personal settings ...
a2ea1fd
So much clang!
480037b
@fschrempf
Copy link
Contributor

Thanks for working on this. Can you remove your personal settings from the branch? And can you put the PR in "Draft" mode until it is ready (CI is green, etc.)? I can try to find some time for testing when it is ready.

@Trainbird
Copy link
Contributor Author

Personal settings were removed in the second commit if I'm not mistaken?

Also see discussion here: https://forum.espuino.de/t/reduzierung-der-defines-stattdessen-einstellungen-in-web-ui/2798

@Trainbird Trainbird marked this pull request as draft November 7, 2024 06:33
@fschrempf
Copy link
Contributor

Personal settings were removed in the second commit if I'm not mistaken?

Doesn't seem so. Just look at the overall changes of this PR and there are plenty of unrelated changes in settings.h.

@Trainbird
Copy link
Contributor Author

Trainbird commented Nov 23, 2024 •
edited
Loading

Doesn't seem so. Just look at the overall changes of this PR and there are plenty of unrelated changes in settings.h.

You're right, I am always confused with which version I compare to and I totally missed that. Using settings-override.h now to avoid that problem in the future - hopefully! 😂

@tueddy tueddy marked this pull request as ready for review November 24, 2024 11:41
@tueddy tueddy merged commit 8323438 into biologist79:dev Nov 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Trainbird @fschrempf @tueddy