VCF annotation via asynchronous request-response pattern #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… restapi and worker Defend against null kwargs in task result Change worker AnyVar app init scheme to work with different Celery pool types
|
Hey @ehclark , apologies for the delay. I have been busy with grant writing. I can review this next week. |
|
Thanks @korikuzma. No rush. I am going to need to make some additional tweaks anyway and will be out next week. I have reverted it to a draft. But if you want to take a quick look next week just to make sure it looks directionally correct that would be helpful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also #107
The annotation of a large VCF file with VRS IDs can run for a long time. A synchronous request-response pattern where the client is waiting for a response can lead to instability and dropped connections in many environments. For long running processes, a better option is an asynchronous request-response pattern. The client submits a request and receives a 202 response and polling location. The client polls at some interval, receiving a 202 if the request is still pending, a 200 and the result if the request is completed, or a 500 if the request failed.
AnyVar uses the Celery distributed task queue for task management and result caching. The asynchronous feature is optional and the changes for this PR are backwards compatible.
See the README-async.md file for detailed documentation of the async feature and how to enable it.
Closes #107