General improvements #519
Merged
General improvements #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- improved HTTP Requests logging
- added comment for future me
- changed icons colors to match Kodi color pattern - applied icons to "Tags", "Years", "Seasons" main menu list items - improved readability which arts are being applied to main menu list item - disabled set_content (because of hits - was unable to set custom icons)
- added command descriptions - improved commands visibility, commands have own icon now
|
Not the biggest fun of thumbnails for "filters" but other than that I really like the cmd icon. |
bigretromike
approved these changes
Nov 2, 2023
| data = json.dumps(data).encode("utf-8") | ||
| req = Request(url, data=data, headers=headers, method="PUT") | ||
| else: | ||
| print(f"Unknown === {url}") | ||
| debug(f"Unknown === {url}") | ||
|
|
||
| print(f"Sending HTTP request: {req.method} {req.get_full_url()}\r\nHeaders: {req.headers}\r\nData: {req.data}") |
There was a problem hiding this comment.
do we need duplicate information ? I understand that we can ditch print, or convert it to debug but both print same data :-)
There was a problem hiding this comment.
We could get rid of prints, but prints do not appear in kodi.log unless set debug mode in Kodi, not plugin settings
Which one? Those icons were already in resources :D |
|
@SteveMavic bump version ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From:
To:
