Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ios safari infinite loader and time parameter #241

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

DaniilVdovinov
Copy link

Fix iOS safari infinite loader and time parameter

I noticed that in version 4.+ in mobile safari, simultaneous playback of the screen share and a webcam did not work. In version 5.0.0, this bug was fixed (or I updated ios), but in some cases in safari, when opening the page, the loader remained even after loading all the resources. There was also the bug with the t parameter #80

Docs

I think it's related to safari webkit. Safari does not allow you to play more than one <video> with sound on the page.
Here are links to explore: webkit bugs, webkit blog, possible solution

Added

  • autoPlay attribute to screen share and webcam <video>
  • pause() after screen share initialization to prevent immediately screen share playback

@pedrobmarin
Copy link
Collaborator

Hi @DaniilVdovinov , thanks for your contribution.
Have you ever signed BigBlueButton's CLA?

@antobinary
Copy link
Member

Hi @DaniilVdovinov

Thank you for this contribution!

Just to give a bit more info on the CLA @pedrobmarin mentioned -- Could you please confirm if you already sent in the signed Contributor License Agreement? See https://docs.bigbluebutton.org/support/faq.html#why-do-i-need-to-sign-a-contributor-license-agreement-to-contribute-source-code
Thanks in advance!

@DaniilVdovinov
Copy link
Author

@antobinary Hi! I sent CLA

@antobinary
Copy link
Member

Thank you @DaniilVdovinov
Your CLA was received and all looks good!

@pedrobmarin
Copy link
Collaborator

pedrobmarin commented Jun 6, 2023

I'm not sure why we don't set the screenshare video muted. Maybe this could work as a solution as well. I still don't understand why we'd need to pause this media. It should be controled by the synchronizer... @antobinary do you think anyone could check on this?

@GuiLeme
Copy link
Contributor

GuiLeme commented Jul 20, 2023

Hey guys, I didn't quite get it, the safari you are talking about is the desktop one or the iphone's?

Because, I tested here and found the following issue: #247 I searched here in the repo and didn't find any known issue regarding that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants